Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compilation failure on gcc 13, added includes, tests fine #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed compilation failure on gcc 13, added includes, tests fine #710

wants to merge 1 commit into from

Conversation

commel
Copy link

@commel commel commented Aug 16, 2023 •
edited
Loading

This Pull Requests fixes the compilation failures on gcc 13 (g++) on Linux. I've added the includes where the numerics where used. The tests built fine and executed without errors:

xxxx> ./xlnt.test 
..........................................................................................................................................................................................................................................................................................................................

Run: 314
Passed: 314
Failed: 0

Superseeds #708 and #704 because I've looked at all the files and executed the test suite and PR authors don't respond.

@commel
Fixed compilation failure on gcc 13, added includes where integers us…
6fca326 
…ed and include was missing. All tests run file
@commel
Copy link
Author

commel commented Aug 16, 2023

Hi @tfussell could you merge this, so I can return using the repo instead of a patched version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@commel